Several Crashes (FIXED)

[PaRaDoXoS]

Hey, I played around with Skyline a bit an I already got Several Crashes:

Camera in Orbit mode: Clicking an Entity while orbiting another.

Random at dragging (a preshipped) Asset to the Scene. Can't remember which, so can't reproduce.

Clicking an Entity in the left menu while playing the Scene in the editor (Tested BotArena2).

Dragging a mesh into the Entity List

[SolarPortal]

Thanks, we are disabling camera orbit mode as it does not work.

For the random drag crash it would be good to have a reproducible error

Clicking a normal model type entity should not crash but lights do I believe.

Thanks for your input, we will fix what we can

[PaRaDoXoS]

in BotArena clicking a bot lead to a crash.

just dragged ogre to the scene -> no problem.
dragged to entity list -> crash.

[SolarPortal]

Thanks. You can't drag to entity list yet so this is definitely a bug. Thanks again

[PaRaDoXoS]

Not reproducable crash: generate Terrain (after removing it)

Edit model material of vegetation (reproducable)

[PaRaDoXoS]

Wow... found a few reproducable ones, that I really find critical. Some Lua-Functions can cause scripts to stop (annoying, but debuggable). BUT: some Lua-Errors couse the Editor to crash in Play-The-Game-Mode. This is reproducable. Here those which I found. Will extend the List when I find more:

Code: Select all

ray.raycastToCursor();
selid = entity.getLastHitID();


Crashes when clicking into background.

Code: Select all

entity.getPosition(0);


Crashes Editor for non-existing entity-id

Code: Select all

sky.lprint(nil);


script stops.

[SolarPortal]

great finds will look at these before the release

[PaRaDoXoS]

3 other snippets, that crash:

Code: Select all

entity.setPosition(0,*,*,*);

Code: Select all

entity.getMaterialName(0,*);

Code: Select all

entity.getMaterialName(eid,-1); -- Runetime-Error, then Editor Crash

what works:

Code: Select all

entity.getMesh(0);

Code: Select all

entity.getMaterialName(eid,5); -- submesh5 non-existent

Code: Select all

entity.getName(0);

Code: Select all

entity.getTagFromID(0);

[CreativeOcclusion]

@PaRaDoXoS
Good job finding all of these crashes...This will make the engine more stable for the future...

[StarFire]

Thanks for the Bugz.

Fixed: No check where an object existed.

Code: Select all

ray.raycastToCursor();
selid = entity.getLastHitID();


Fixed.Invalid IDs should now be stable. This is all entity.method() as they all contained this potential invalid id crash. This should clear all of the remaining entity id crashes.

Code: Select all

entity.getPosition(0);

entity.setPosition(0,*,*,*);



Fixed out of ranges sub indexes.

Code: Select all

entity.getMaterialName(0,*);


No Problem here. Did a test and in my update loop with a screen print directly after and this worked fine.
Incorrect use of some lua with halt scripts as they are broken, need good compiler checker to get around this. May be some one wants to write a QTScintilla editor for us

Code: Select all

sky.lprint(nil);


All have been tested with new checks in place and now stable. I am sure there are a few more of these dotted around. Some are due to core changes that have taken place to improve the scene list. We have been talking about upgrading a system wide change to the checks and balances as we have seen areas where we may be able to get some better performance and create a stronger debug system. But all of this will be a while off so for now we will keep fixing commandsaas you find them for us.
Good hunting ParaDoXos